spring-projects / spring-webflow

Spring Web Flow
https://spring.io/projects/spring-webflow
Apache License 2.0
322 stars 228 forks source link

Migrate tests from JUnit 3 to JUnit 5 [SWF-1739] #914

Closed spring-operator closed 1 year ago

spring-operator commented 4 years ago

Rossen Stoyanchev opened SWF-1739 and commented

Currently Web Flow's own tests still depend on the JUnit 3 class hierarchy and could be migrated to JUnit 5.


Affects: 2.5.1

Issue Links:

1 votes, 3 watchers

spring-operator commented 4 years ago

Rossen Stoyanchev commented

Related PR #97 with migration to JUnit 4.

spring-operator commented 4 years ago

Sam Brannen commented

FYI: I used the following two shell scripts to migrate the test suite for the Spring Framework.

spring-operator commented 4 years ago

Sam Brannen commented

Related to #915

spring-operator commented 4 years ago

Etienne Dysli Metref commented

I used sed to migrate. ;) What makes jumping from 3 to 5 tricky is that the message argument of assertion methods moved from the first to the last position. Instances of assertEquals still compile, but are incorrect.

spring-operator commented 4 years ago

Etienne Dysli Metref commented

Changes to migrate to JUnit 5 are ready for review in PR#99. I'm looking forward to your comments. :)