search

spring-projects / spring-webflow

Spring Web Flow
https://spring.io/projects/spring-webflow
322 stars 229 forks source link

Convert internal tests to JUnit 5 #99

Closed edysli closed 4 years ago

edysli commented 4 years ago

As discussed in #97 and SWF-1739, first convert the project's tests to JUnit 5.

edysli commented 4 years ago

@rstoyanchev could you please check that the Gradle build really executes all tests with the correct classpath? I've had tests fail in Eclipse (because of wrong argument order for assertEquals()), but not when running ./gradlew build and I'm not familiar enough with Gradle to spot the difference.

rstoyanchev commented 4 years ago

@edysli, apologies for the delay and thanks for the constribution! The tests pass for me both command line and in my IDE which is IntelliJ IDEA. I've only opted to consolidate all changes into two commits but no other changes aside from that.