Convenience constructor for SimpleUsernamePasswordCallbackHandler [SWS-745]

[gregturn]

Eirik Lygre opened SWS-745 and commented

The class org.springframework.ws.soap.security.xwss.callback.SimpleUsernamePasswordCallbackHandler has two properties "username" and "password", and only a default constuctor. When using this class, I always find myself writing this code:

SimpleUsernamePasswordCallbackHandler callback = new SimpleUsernamePasswordCallbackHandler ();
callback.setUsername(username);
callback.setPassword(password);
doSomething(callback);

Of course, I'd love to write this instead, which would be a, hm, productivity booster?

doSomething(new SimpleUsernamePasswordCallbackHandler (username, password));

Hence, the request: Add the required constructors to make this work:

public class SimpleUsernamePasswordCallbackHandler extends AbstractCallbackHandler implements InitializingBean {
   ...
   public SimpleUsernamePasswordCallbackHandler ();
   public SimpleUsernamePasswordCallbackHandler (String username, String password);
   ...
}

---

Affects: 2.0.3

Attachments:

• spring-ws-security.patch (976 bytes)

Referenced from: commits https://github.com/spring-projects/spring-ws/commit/0f277d4e4a06c7e5b73a21495d5cb79fb83e372f

[gregturn]

jaminh commented

Here is a patch for the new constructor

[gregturn]

Arjen Poutsma commented

Closing old issues