spring-projects / sts4

The next generation of tooling for Spring Boot, including support for Cloud Foundry manifest files, Concourse CI pipeline definitions, BOSH deployment manifests, and more... - Available for Eclipse, Visual Studio Code, and Theia
https://spring.io/tools
Eclipse Public License 1.0
870 stars 203 forks source link

[vscode Concourse extension] Property 'commit_message' not recognized for semver resources #655

Closed ThibaultDelaune-pro closed 3 years ago

ThibaultDelaune-pro commented 3 years ago

Describe the bug The vscode Concourse extension raise an error when a semver resource has a 'commit_message' property set for git driver.

To Reproduce

resources:
- name: my_resource
  type: semver
  source:
    driver: git
    uri: ((repo_uri))
    private_key: ((private_key))
    branch: master
    file: version.txt
    commit_message: "[skip ci] my commit message"

cf. https://github.com/concourse/semver-resource

kdvolder commented 3 years ago

Confirmed that 'commit_message' is missing from our schema and should be added.

In the same part of the schema and the above linked docs I also found that a property skip_ssl_verification is missing from our schema. So I will add support for both of these:

Sample code (based on above sample but addinng skip_ssl_verification to it as well).

resources:
- name: my_resource
  type: semver
  source:
    driver: git
    uri: ((repo_uri))
    private_key: ((private_key))
    branch: master
    file: version.txt
    commit_message: "[skip ci] my commit message"
    skip_ssl_verification: true