spring-projects / sts4

The next generation of tooling for Spring Boot, including support for Cloud Foundry manifest files, Concourse CI pipeline definitions, BOSH deployment manifests, and more... - Available for Eclipse, Visual Studio Code, and Theia
https://spring.io/tools
Eclipse Public License 1.0
870 stars 203 forks source link

[refactoring] [validation] final polishing work #911

Closed martinlippert closed 1 year ago

martinlippert commented 1 year ago

Version validations:

Reconciling (open rewrite):

Quick fixes for version upgrades:

Refactorings dialog:

The last piece is probably the most difficult one to get right, since I am not sure yet on what the right structure for this is. At the moment this is really just a random collection of stuff in the dialog and the title of the action on the context-menu is engineering driven. I really would like to change that.

One option could be to have one context menu item: Upgrade Project to Newer Spring Boot Version, which them shows only a list of items saying Convert from Spring Boot 2.6 to 2.7, Convert from Spring Boot 2.7 to 3.0, etc. All with the same names and the same structure, so that it is easy to see which one converts from what version to what other version. Then, we could have another context-menu, say Additional Project-Wide Refactorings (based on OpenRewrite)..., that then has another list of recipes...

Or we keep one dialog, but group the recipes in sections: One for Spring Boot version upgrades, one for other upgrades, one for best practices, etc. But I think the Spring Boot version upgrade topic is front and center, so it deserves its own context menu item.

BoykoAlex commented 1 year ago

Should be fixed with 88b591450a7725f587622ed3c37e9bc75b837608 and c262b5ac50306de5c46fc62cea64b638f6f2ab46