search

spring-social / spring-social-google

Spring Social extension with connection support and an API binding for Google
https://spring-social-google.github.io/spring-social-google/
Apache License 2.0
213 stars 164 forks source link

Do you plan on adding support for Plus Domains? #60

Open nodoze opened 10 years ago

nodoze commented 10 years ago

Thanks for the good work. Very useful. I would be interested in assisting and adding Plus Domains capabilities such posting and and other circle management tasks. Thoughts?

GabiAxel commented 10 years ago

I welcome contributions. Fork the project, add support for G+ domains and submit a pull request. Please follow Spring's code style guidelines and write Javadoc and unit tests like the rest of the project. I suggest you create a "domains" package under "plus" and add your new content to it.

nodoze commented 10 years ago

Thanks. I will give it a spin as time permits. Have you thought about integrating the google library to use their binding?

Sent from my iPad

On Sep 6, 2014, at 3:46 AM, Gabriel Axel notifications@github.com wrote:

I welcome contributions. Fork the project, add support for G+ domains and submit a pull request. Please follow Spring's code style guidelines and write Javadoc and unit tests like the rest of the project. I suggest you create a "domains" package under "plus" and add your new content to it.

— Reply to this email directly or view it on GitHub.

GabiAxel commented 10 years ago

That's what Google.getAccessToken() is for - you can use Spring Social Google for the authentication process and use the access token with Google's Java library or any other code that interacts with the HTTP API.

Spring Social projects (not only this one) interact directly with the HTTP APIs, and the common core allows the specific projects to get a lot of free stuff out of the box, so there isn't much sense in wrapping another library to interact with the APIs. They can co-exist in the same project just fine as mentioned above.

nodoze commented 10 years ago

I did some tests using the getAccessToken() approach yesterday. There are some scope conflicts between the two APIs. Also it¹s not as clean as I¹d like it to be since it creates competing bindings / model classes for the same API. I¹m very familiar with most aspects of the spring framework and very much appreciate the work the community is putting in to make free software available to everyone. Since I¹ve been largely on the receiving end till now I¹ve figured I would start paying back a bit. Anyway, I will play around with and let you know how it goes.

From: Gabriel Axel notifications@github.com Reply-To: GabiAxel/spring-social-google <reply@reply.git hub.com> Date: Saturday, September 6, 2014 at 12:03 PM To: GabiAxel/spring-social-google spring-social-google@noreply.github.com Cc: Oliver Eberle oeberle@gmail.com Subject: Re: [spring-social-google] Do you plan on adding support for Plus Domains? (#60)

That's what Google.getAccessToken() is for - you can use Spring Social Google for the authentication process and use the access token with Google's Java library or any other code that interacts with the HTTP API.

Spring Social projects (not only this one) interact directly with the HTTP APIs, and the common core allows the specific projects to get a lot of free stuff out of the box, so there isn't much sense in wrapping another library to interact with the APIs. They can co-exist in the same project just fine as mentioned above.

‹ Reply to this email directly or view it on GitHub https://github.com/GabiAxel/spring-social-google/issues/60#issuecomment-547 24765 .

vauvenal5 commented 7 years ago

I know this is not completely on topic but since you discussed here wrapping the Google API library I decided to continue here. The Spring Social documentation itself suggests integrating API bindings if they exist instead of writing new bindings: http://docs.spring.io/spring-social/docs/1.1.4.RELEASE/reference/htmlsingle/#integrating-an-existing-java-api-binding

So basically my question is, where is the advantage in providing another binding?