CONNECTUSER is unusable: engine name & version missing, username from server missing

[abma]

engine name & version needed!

[abma]

also there is no direct way for the client to report to the sender, that it couldn't connect for some reason.

-> CONNECTUSER:server should contain origin username

this is also needed for debugging / finding problems / ignore lists / etc.!

[abma]

maybe add map & game too, to allow the lobby client to verifiy if it can directly start or not?!

[abma]

hmm, better: use same named parameters like in setscripttags!

so it can be extended in future!

[Licho1]

Add a nema for script too to allow anonymous players.

[gajop]

Since it was never implemented, make it a JSON and have userName + engine as fields? Map/game is redundant as it'll be verified on connection. That existance should be verified beforehand. (It could be an optional parameter though..?) Engine is only needed because it's used to connect. PS: Imo, in the future please don't add documentation to the LobbyProtocol of stuff that isn't implemented on uberserver (or any protocol-abiding alternative which might exist).

[abma]

Since it was never implemented, make it a JSON and have userName + engine as fields?

yes!

Map/game is redundant as it'll be verified on connection. That existance should be verified beforehand. (It could be an optional parameter though..?)

agreed, if its checked beforehand its not needed.

PS: Imo, in the future please don't add documentation to the LobbyProtocol of stuff that isn't implemented on uberserver (or any protocol-abiding alternative which might exist).

yep, its confusing for others and more work, agreed as well.

[abma]

for the reference: https://github.com/spring/LobbyProtocol/commit/4566c55f30aecfd3b17c92933c28d22e7eb26a5d

[silentwings]

CONNECTUSER was removed, can close