search

spring / LobbyProtocol

lobby protocol for the spring rts engine
https://springrts.com/dl/LobbyProtocol/
10 stars 12 forks source link

SETSCRIPTTAGS examples are uppercase #3

Closed abma closed 9 years ago

abma commented 12 years ago

but they seem to be converted to lowercase...

https://github.com/spring/LobbyProtocol/blob/master/ProtocolDescription.xml#L1740

https://github.com/lunixbochs/uberserver/blob/master/Protocol.py#L1616

don't know if there are other examples that should be lowercase

renefritze commented 12 years ago

check handling in springLS?

abma commented 12 years ago

uhm... what?

uberserver converts all tags to lowercase: https://github.com/lunixbochs/uberserver/blob/master/Protocol.py#L1630

i think it wouldn't work, if tags aren't converted to lowercase on server side.

update it in docs, that they are all converted to lowercase and/or check if thats fine for unitsync/games/maps/...

abma commented 9 years ago

was fixed some time ago in docs

hoijui commented 9 years ago

SpringLS converts keys to lower case when parsing the arguments to SETSCRIPTTAGS. it does so since 2007, right after when SETSCRIPTTAG (supported setting only one tag at a time) was replaced with SETSCRIPTTAGS (supportes multiple tags at once), in this commit by trepan: https://github.com/spring/SpringLS/commit/cdf42f0407284ee21ba1b21e01473f8f926264a8