search

spring / LobbyProtocol

lobby protocol for the spring rts engine
https://springrts.com/dl/LobbyProtocol/
10 stars 12 forks source link

LobbyID in AddUser command is not indicated as a sentence #43

Closed MasterBel2 closed 4 years ago

MasterBel2 commented 5 years ago
image

Minor issue, but if you're expecting this to be a sentence, you'll parse it incorrectly. Description currently says it's not:

image

Let me know how this repo works (do I just change the XML file?) and I'll create a PR for this and all future issues to save you time instead.

Regards, ~MasterBel2

abma commented 5 years ago

do I just change the XML file?

yes.

i guess you are referring https://github.com/spring/LobbyProtocol/blob/master/ProtocolDescription.xml#L925 ?

atm it seems to be "the rest of the string" and not a sentence:

https://github.com/spring/uberserver/blob/master/protocol/Protocol.py#L739

MasterBel2 commented 5 years ago

Being "the rest of the string" seems to fit the description of a sentence. See protocol description:

image

Moreover, all other commands I've come across with "rest of the string" use a sentence for this purpose, and if it's optional, they mark it as optional

image image image

Is there some hidden difference between a sentence and "the rest of the string"? If so, can this distinction be removed?

MasterBel2 commented 5 years ago

Looking at uberserver's implementation, "the rest of the string" seems to be synonymous with a sentence, unless it's explicitely a word?