search

spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

deleting users who didn't play/login? #225

Closed silentwings closed 7 years ago

silentwings commented 7 years ago

I think https://github.com/spring/uberserver/commit/d4326a00e7b3006056505ae33e22eea5a201eb2c will cause a lot of grief, and could even lower BAs players numbers in the long run.

It's not uncommon for BA players to take a few weeks or months, or in some cases even years, away from playing BA, and then later return. I think they're much more likely to carry on doing this if their accounts don't vanish.

Possible remedy is that user accounts that have got significant ingame time (say, gold star or higher) wait longer (I'd say 2y+ is sensible) without a login before being deleted.

edit: opps, misunderstood, sorry!

abma commented 7 years ago

i think you didn't understand or i miss-spelled:

only players who have no ingame time (!!!) are deleted

so a minute ingame time prevents the deletion of the account for 3 years.

imo thats ok, also its just a small adjustment to fit better.

abma commented 7 years ago

no worries, its good when you ask / give feedback / complain. :)

Yaribz commented 7 years ago

FYI, several autohosts were using dedicated rank-0 lobby accounts to upload replays on the replay site (as indicated in the README.replay-upload file). So this change broke replay uploading for them, and currently a lot of replays are lost...

abma commented 7 years ago

autohosts usually have ingame time...

Yaribz commented 7 years ago

Please re-read my message

abma commented 7 years ago

the cleanup exists since years. so this change didn't introduce problems, it just made them appear faster.

Yaribz commented 7 years ago

exactly

Maybe we should discourage autohost owners to create dedicated accounts for replay-uploading if they have to re-create them every month.

abma commented 7 years ago

the problem is that a dedicated user just for uploading is used IMO.

abma commented 7 years ago

https://github.com/dansan/spring-replay-site/issues/108

gajop commented 7 years ago

How about you only delete accounts which didn't login in the last 30 days and have 0 ingame time?

abma commented 7 years ago

please read the code... thats exactly how it works currently.

logging in via replays.springrts.com doesn't update the last login, see the bug report at spring-replay-site. its argueable if this should be changed. ATM the api for logging in has only read-only permissions to the database of the lobbyserver.

IMHO its still favorable to use the same account for uploading and the autohost account. using different accounts is confusing and problems with the account very likely will be unnoticed.

gajop commented 7 years ago

good then, i went by the title and comments, which suggested otherwise.

I think there are accounts which aren't used to play/spectate games so this is something to keep in mind. Sending an email warning the users after some time would be a good policy. (The email field is optional iirc?)

abma commented 7 years ago

locked conversation: i'm really frustrated about invalid comments. i don't have the time for this.

(because of the forum link)