spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

Properly implement end-battle notify #252

Closed specing closed 6 years ago

specing commented 6 years ago
springlobby/src/gui/battlelist/battledataviewcttrl.cpp:
void BattleDataViewCtrl::OnNotifyGameEnd(wxCommandEvent& /*unused*/)
{
    const IBattle* battle = GetSelectedItem();

    if (battle == nullptr) {
        return;
    }

    //Send user (belived to be autohost bot) private message with "!notify" command
    User founder = battle->GetFounder();
    founder.Say("!notify");
}

This is bad.

silentwings commented 6 years ago

More detail needed, or perhaps you are interested in something that is implemented by SPADS.

There is no end battle notify command in the lobby protocol, nor chanserv.

abma commented 6 years ago

hm, this clearly is a feature request for the lobby client: the ingame status of the battlehost is send.

the !notify command really is not needed.