search

spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

BATTLEMUTE command cannot be called #258

Closed silentwings closed 5 years ago

silentwings commented 6 years ago

It's not possible for mods to call the BATTLEMUTE command, afaics.

I think the issue is that it is missing from the (mod) access levels table https://github.com/spring/uberserver/blob/bbf85ae021b80d8ae72de3c661051b0d3c56d667/protocol/Protocol.py#L20 with the result that trying to BATTLEMUTE leads to https://github.com/spring/uberserver/blob/bbf85ae021b80d8ae72de3c661051b0d3c56d667/protocol/Protocol.py#L286

The KICKBAN command presumably suffers the same bug, but I haven't tested this.

abma commented 6 years ago

KICKBAN + BATTLEMUTE are part of some major refactoring:

https://github.com/spring/uberserver/blob/master/protocol/Protocol.py#L3058

untested:

JSON {'BATTLEMUTE': {'username': 'usertomute'}}

also i'm not sure if the changes are applied on the server yet as some recent changes require a server restart + testing:

i.e. https://github.com/spring/uberserver/commit/1c2059da66af19862097f4c42256ba9fbaa62188

silentwings commented 6 years ago

Is JSON {'BATTLEMUTE': {'username': 'usertomute'}} the intended usage command? Imo it is too much detail to type. I expected simply BATTLEMUTE 'usertomute'.

abma commented 6 years ago

no, right click user -> mute (which isn't implemented yet)

silentwings commented 6 years ago

maybe right click user -> battlemute/channelmute, to differentiate from global mute

silentwings commented 6 years ago

Will BATTLEMUTE affect ingame chat or just channels/battles? (I am unsure if it's best that it does or not.)

abma commented 6 years ago

no. it requires spad to support / read the cmd from the lobby server and then (afaik) execute a mute command inside the battle for the user.

silentwings commented 5 years ago

Removed in #282, channel mute can now do this