disallow non-dl-able spring versions on botflagged hosts

[silentwings]

I think that Spring versions that are no longer available for auto-dl should not be playable on the lobbyserver.

Could return OPENBATTLEFAILED in response to OPENBATTLE in such a case

• if its possible to check if engine is auto-dlable, then do that
• if not, could replace the admin command SETLATESTSPRINGVERSION (which afaics is currently obselete) with a SETMINBRANCHVERSION <branchName, minorVersion>

Also this could allow master builds to be removed when they become unuseable e.g. the ABI issue.

[silentwings]

P.S do you think it would be possible to set up a dev envir for uberserver on windows, or no chance?

[abma]

P.S do you think it would be possible to set up a dev envir for uberserver on windows, or no chance?

its written in python: yes. i did not test it but the required libs runs on windows, too.

[abma]

i guess this needs some daily task which fills in a whitelist with downloadable engine versions.

edit: daily task + whitelist is bad as new versions can always appear: should be a blacklist or min version as suggested.

[gajop]

This could (read: will) cause problems when someone in the future creates a yet-unreleased version of the engine (e.g. commit -> push -> try to host -> oh the whitelist isn't updated yet! -> fail)

On Thu, May 31, 2018 at 4:04 PM abma notifications@github.com wrote:

i guess this needs some daily task which fills in a whitelist with downloadable engine versions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spring/uberserver/issues/260#issuecomment-393430041, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD9hb5lc8L9ftkGxLYAP36PS0P9aLXRks5t35YKgaJpZM4UUfSx .

[silentwings]

Hence the usage of a blacklist, rather than a whitelist. (Or, perhaps, an automated whitelist.)

[silentwings]

With help of TurBoss I now have a dev env set up (on windows!) for Uberserver.

The instructions for setting up uberserver need some updating. I think TurBoss knows what is needed, but I don't think I can write them.

However, https://github.com/springlobby/springlobby/issues/828 (I think) prevents me from using SL with my local lobbyserver, and WebLobby (which is able to connect) seems not able to host battles, so currently I can't try and fix this!

edit: success by downgrading SL to 0.260

[silentwings]

Occurs to me that users may want old dev spring versions for good reason e.g. bisecting, comparison.

-> The restriction should apply only to botflagged hosts.

[silentwings]

already recorded as #192, so will close