search

spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

Registration sends me the agreement message despite me trying to register with an existing username #350

Closed gajop closed 5 years ago

gajop commented 5 years ago 
[f=-000001] ErrorEvent, events_2018_04_25:Username is not available, please try another., Info
[f=-000001] [ServerMessage] REGISTRATIONDENIED Username is not available, please try another.

After which I'd get

[f=-000001] [ServerMessage] AGREEMENT You agree not to use any abusive, obscene, vulgar, slanderous, hateful, threatening, sexually-oriented or any other material that may violate any applicable laws. Doing so may lead to you being immediately and permanently banned, and to your service provider and relevant legal authorities being informed of your actions and of data which personally identifies you.
[f=-000001] [ServerMessage] AGREEMENT 
...
[f=-000001] [ServerMessage] AGREEMENT By using this service you hereby agree to all of the above terms.
[f=-000001] [ServerMessage] AGREEMENT 
[f=-000001] [ServerMessage] AGREEMENTEND
silentwings commented 5 years ago

I haven't managed to reproduce this, could you attach the full log of what's being sent/recieved?

The AGREEMENT sequence is only ever sent in response to a LOGIN. I think it is possible you are sending a LOGIN (for a valid but un-agreed user) without realizing.

gajop commented 5 years ago

It's quite possible. Let me check again and get back to you.

gajop commented 5 years ago

Yep, seems to be bad Chobby code. My bad.