search

spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

db changes #370

Closed silentwings closed 4 years ago

silentwings commented 4 years ago

hopefully its clear from diff of the structs in SQLUsers.py what needs to be done on db side

https://github.com/spring/uberserver/pull/370/files#diff-898eacbe942e568d1a0f10fa33d4620a

notes: https://github.com/spring/uberserver/issues/359#issuecomment-587850593 https://github.com/spring/uberserver/issues/312#issuecomment-587931559

silentwings commented 4 years ago

I think this is all that goes on the branch, should be ready for db side now

abma commented 4 years ago

did i miss some issue / db change?

abma commented 4 years ago

the new rows (should) be automaticly created when uberserver is started.

only changes / deletes / renames needs to be done by hand:

the script needs to be run before the changed uberserver is started.

silentwings commented 4 years ago

I think we are good to go here, I can try it on the test lobbyserver if there is a script somewhere to execute the schema upgrade?

abma commented 4 years ago

"cat script.sql | mysql lobbydev" should do the trick.

ok, i'll test it as i excpect some errors :-)

silentwings commented 4 years ago

@abma could we get this finished? i can try to test but slightly worried i might break smth.

abma commented 4 years ago

meh, i'm to time optimistic. when you do a mysqldump before doing the changes you always can step back... (AFAIK) i.e.:

mysqldump lobby > lobby.sql

to restore cat loby.sql | mysql lobby

where "lobby" is the database name to backup / recover. so no need to worry about breaking stuff as long the backup is fine :-)

silentwings commented 4 years ago

alright, before i start - would you take a backup that you can restore from, and hide it somewhere that i can't find / accidentally delete, just in case...

abma commented 4 years ago

a dump is made daily at ~6:45 am, see /var/backups/mysql/lobby

only root has read/write permissions, so... shall i make additionally a manual backup?

if so: when?

silentwings commented 4 years ago

a dump is made daily at ~6:45 am, see /var/backups/mysql/lobby only root has read/write permissions, so... shall i make additionally a manual backup?

I don't think I have access to this so I guess we're safe :p