spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project
https://springrts.com/wiki/Uberserver
Other
33 stars 38 forks source link

Joining a battleroom for the second time generates a JOINBATTLEFAILED command #372

Closed Yaribz closed 4 years ago

Yaribz commented 4 years ago

When joining a battleroom for the first time, all is ok:

[12:33:41] <DEBUG> [ B -> S ] JOINBATTLE 419
[12:33:41] <DEBUG> [ B <- S ] JOINBATTLE 419 -2005090239
[12:33:41] <DEBUG> [ B <- S ] JOINEDBATTLE 419 bibim_

But when leaving this battleroom and joining it again, an unexpected "JOINBATTLEFAILED" command is received just before the normal "JOINBATTLE" command:

[12:33:48] <DEBUG> [ B -> S ] LEAVEBATTLE
[12:33:48] <DEBUG> [ B <- S ] LEFTBATTLE 419 bibim_
[...]
[12:33:50] <DEBUG> [ B -> S ] JOINBATTLE 419
[12:33:50] <DEBUG> [ B <- S ] JOINBATTLEFAILED Waiting for JOINBATTLEACCEPT/JOINBATTLEDENIED from host
[12:33:50] <DEBUG> [ B <- S ] JOINBATTLE 419 -2005090239
[12:33:50] <DEBUG> [ B <- S ] JOINEDBATTLE 419 bibim_

Note: Logs are from the IRC bridge, as seen when joining the special channel "&debug_lobby". "B -> S" means command sent by the bridge to the lobby server. "B <- S" means command received by the bridge from the lobby server.

silentwings commented 4 years ago

Fixed by https://github.com/spring/uberserver/commit/f2b8330d4195a05b23d277ed5b14562badd9b71a