added a 10000 hour rank

spring / uberserver

uberserver, a matchmaking/chat lobby server for the spring rts project

https://springrts.com/wiki/Uberserver

Other

33 stars 38 forks source link

added a 10000 hour rank #380

Closed Ruwetuin closed 3 years ago

Ruwetuin commented 3 years ago

I already filed a Springlobby pull request to add a rank icon for it

https://github.com/springlobby/springlobby/pull/979

abma commented 3 years ago

afaik not possible, that would be an overflow: https://springrts.com/dl/LobbyProtocol/ProtocolDescription.html#MYSTATUS:client

b2-b4 = rank (see Account class implementation for description of rank) - client is not allowed to change rank bits himself (only server may set them).

thats 3 bits, max is 111 (binary), which are 7(decimal) ranks which we already have.

abma commented 3 years ago

its already a comment in the code:

https://github.com/spring/uberserver/pull/380/files#diff-7ed989e695c7bf59655c5b9fef81fcfcd09f29895a8bcf029d93a9e884c6d6d0R22

sorry, thats not possible without larger protocol changes!