search

spring / upq

extracts metadata of game and map files of the spring engine
https://springfiles.springrts.com/
GNU General Public License v3.0
2 stars 5 forks source link

Upload feature broken for game packages #92

Closed springraaar closed 1 year ago

springraaar commented 1 year ago

I've tried to upload a MF v2.09test game package to springfiles.

It fails and a stack trace is shown on the browser

676 677                 metadata = data["metadata"] =>  678                 data["map_width"] = int(metadata['Width']) <---- fails here 679                 data["map_height"] = int(metadata['Height']) 680

apparently it's trying to read a map-related property from the game package's metatada which lacks it

abma commented 1 year ago

whats inside the "package"? i guess it has some file inside it which makes unitsync detect it as map. just remove this file and it should be fine.

abma commented 1 year ago

also thats the wrong approach: if its a game it should be added to rapid

abma commented 1 year ago

or the file is just broken: check unitsync.log

springraaar commented 1 year ago

There's issues on extract_metadata.py that were introduced on my PR a while ago that cause this, i'm trying to fix it atm and I'll make a PR with it later today

springraaar commented 1 year ago

I think I fixed it, PR on https://github.com/spring/upq/pull/93