search

springbok / MLM2PRO-GSPro-Connector

GSPro Connector for the MLM2PRO Launch Monitor
GNU General Public License v3.0
47 stars 6 forks source link

Mevo+ "FS GOLF PC" app closing #124

Open agn507 opened 1 day ago

agn507 commented 1 day ago

If I need to restart the "FS Golf PC" app and close it down the connector will send a shot. Attached is the replay of the shot sent when I closed the app. Is there a way to avoid this other than pausing the mevo+ device in the connector app?

https://github.com/user-attachments/assets/eb5834ee-d90c-4e49-843b-77af59d46914

wonder99 commented 1 day ago

Is the extra shot a repeat of your previous shot? Can you attach the log file (from appdata/logs directory) when this happens? The Pause button is the recommended way to handle this though.

agn507 commented 1 day ago

I wasn't able to reproduce but will be sure to check the logs right when it happens next time. I did track back to where I "think" the log is about the time when this happened which was shortly before making this post.

I'll attach log file here. Search for "2024-10-25:13:05:12". That is about the time it happen mlm2pro-gspro-connect.log ed

wonder99 commented 1 day ago

OK, what I think I see in your log is that you closed FS Golf at 2024-10-25:13:05:07,725. At that point, you can see it reading a very incorrect 'speed' metric, which is probably because it's the ROI box it was looking at has disappeared. The connector cleans up the metrics as best it can, and sends it to GSPRO. This happens before the connector even noticed that the FS Golf window has disappeared at 2024-10-25:13:05:08,823. Because the connector saw two metrics change, it decides it's a valid new shot and sends to GSPRO. I'm not sure how to avoid that right now, but I think it's reasonable to ignore shots with VLA of 0.5 for Mevo+, which is probably the reason you closed FS Golf in the first place. I'll get you a beta version to test for the VLA 0.5 situation (#123 ), and you'll need to Pause the connector before closing FS Golf for now. We'll see if @springbok has other ideas.