search

springbok / MLM2PRO-GSPro-Connector

GSPro Connector for the MLM2PRO Launch Monitor
GNU General Public License v3.0
49 stars 6 forks source link

Updates #46

Closed springbok closed 1 year ago

wonder99 commented 1 year ago

Thanks for this change, it's what I had in mind. But now I think this wasn't the issue. The problem is that my example was a chip shot with a ball speed of 15 mph which got read at 153. Since 153 is already less than the 200 mph ball speed limit, the correction doesn't kick in. I think we may need to look at club speed too, and calculate smash--this was a smash of 153/17, which would indicate the issue. Maybe the rule would be while smash > 1.7, then keep taking the floor of ballspeed/10? I think max theoretical smash is 1.5, but 1.7 gives a little margin.

wonder99 commented 1 year ago

Similar, though less critical, could be an issue reading club speed too high. This would result in a smash of far less than one, which we can identify readily as an error. I think we could say smash should never be less than 0.8, and if it is, then divide club speed by 10 repeatedly until it is. So the fixing routine could either : divide ball speed (if it's over 200mph), or club speed (if it's over 140), and divide ball speed (if smash is over 1.7), or divide club speed (if smash is below 0.8)

springbok commented 1 year ago

Thanks Paul some great ideas I'll look at implementing your ideas. I've also asked Rapsodo to see if they'd consider moving the labels to above or underneath the numbers similar to exputt which will make it so much more accurate. Not sure they will but worth asking.

On Sat, Oct 7, 2023 at 5:47 AM wonder99 @.***> wrote:

Similar, though less critical, could be an issue reading club speed too high. This would result in a smash of far less than one, which we can identify readily as an error. I think we could say smash should never be less than 0.8, and if it is, then divide club speed by 10 repeatedly until it is. So the fixing routine could either : divide ball speed (if it's over 200mph), or club speed (if it's over 140), and divide ball speed (if smash is over 1.7), or divide club speed (if smash is below 0.8)

— Reply to this email directly, view it on GitHub https://github.com/springbok/MLM2PRO-GSPro-Connector/pull/46#issuecomment-1751263022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJGTBA45WPTJ7ZWIXNQT3X6BG45AVCNFSM6AAAAAA5VHTNDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGI3DGMBSGI . You are receiving this because you modified the open/close state.Message ID: @.***>