springer-math / Mathematics-of-Epidemics-on-Networks

Source code accompanying 'Mathematics of Epidemics on Networks' by Kiss, Miller, and Simon http://www.springer.com/us/book/9783319508047 . Documentation for the software package is at https://epidemicsonnetworks.readthedocs.io/en/latest/
MIT License
150 stars 61 forks source link

Figure 1.4(b) #54

Open RSMacKay opened 4 years ago

RSMacKay commented 4 years ago

It seems to Marcus Miller and me that Figure 1.4(b) is incorrect. The deterministic SIR model saturates at a fraction R < 1 and S > 0.

joelmiller commented 4 years ago

You are correct, and I'm shocked that this has been there so long without being noticed. I've hunted down the original code that made this figure, and the error was that I copied some SIS code, over, and didn't correctly normalize by N in S' = - beta I S/N. Instead, I normalized so that it solved S'=-beta IS/(I+S).

Thanks. I'm going to add this to the erratum now.

RSMacKay commented 4 years ago

Dear Joel, Thanks for confirming! Glad to help, but it had my colleague Marcus Miller very puzzled. Best wishes, Robert

On 15 May 2020, at 14:43, joel miller notifications@github.com<mailto:notifications@github.com> wrote:

You are correct, and I'm shocked that this has been there so long without being noticed. I've hunted down the original code that made this figure, and the error was that I copied some SIS code, over, and didn't correctly normalize by N in S' = - beta I S/N. Instead, I normalized so that it solved S'=-beta IS/(I+S).

Thanks. I'm going to add this to the erratum now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/springer-math/Mathematics-of-Epidemics-on-Networks/issues/54#issuecomment-629243554, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APS6SM5TM2S4ESJC6CDFZW3RRVBI7ANCNFSM4NBR4YUQ.

Prof R.S.MacKay FRS FInstP FIMA, go.warwick.ac.uk/rsmackayhttp://go.warwick.ac.uk/rsmackay Director of Mathematical Interdisciplinary Research B2.05 Mathematics Institute, University of Warwick, Coventry CV4 7AL, U.K. phone +44: 24 765 22218, FAX 24182 R.S.MacKay@warwick.ac.ukmailto:R.S.MacKay@warwick.ac.uk