springernature / boomcatch

A standalone, node.js-based beacon receiver for boomerang.
GNU General Public License v3.0
110 stars 33 forks source link

Make unmapped wrapper the default #78

Open hollsk opened 7 years ago

hollsk commented 7 years ago

Currently the default wrapper is statsd, which contains a normalisation step. This makes things kind of confusing for people who just use the default mapper, who wonder why their data has vanished on the way through Boomcatch.

58 was created to remove the normalisation from the existing mappers, but not from the default package - it would probably help to change the default mapper to unmapped instead, so users get a JSON serialisation of the Boomerang payload. This will give us some breathing space to rewrite the rest of the mappers ( #79 ).

hollsk commented 7 years ago

@philbooth do you think this proposal (changing the default mapper from statsd to unmapped ) is a horrible idea? It would obviously be a breaking change.

I've just done it locally and tweaked the tests but now I'm having a crisis of confidence. Save me, Phil!

philbooth commented 7 years ago

OH HAI @hollsk!

Hrrm, I'm not sure if there is a definitive answer here, so probably just go with your gut.

As a rule of thumb, I think it's good for things to just work out of the box without any configuramisation needed. But whether works out of the box means "sends to statsd" or whether it means "shows me all the data", I'm not sure. Struggling to page in all the context tbh.

If the default mapper is unmapped, what would the default forwarder be? Will they work well as a pair?

Or maybe just try it and see what happens? Major version bumps === progress!