search

springernature / frontend-toolkits

Frontend Component Toolkits for the Elements Design System
MIT License
13 stars 3 forks source link

Updates the breadcrumb visibility on mobile #882

Closed nickcall closed 1 year ago

nickcall commented 1 year ago

To bring both the elements and frontend toolkit breadcrumbs in line, I created this PR to hide all but the last two levels of breadcrumb on small screen devices.

tulipdexter commented 1 year ago

Is this breaking? I would consider it a feature (minor)

nickcall commented 1 year ago

Yeah, I had a similar chat with @benjclark. We decided it was breaking as it affects and changes the user experience. Happy to go with the majority as it kind of sits in between a bit.

benjclark commented 1 year ago

Yeah I'm always a little unsure how to apply semver to frontend changes, particularly CSS changes

In my mind if a team implemented a design ok, and then a version change came along that significantly changes (breaks) that visual design then that version should be a "breaking" change

tulipdexter commented 1 year ago

Personally I think that because the change doesn't really affect a part of the UI that the user depends upon, then it's not really a major.

nickcall commented 1 year ago

OK, looking at other "breaking" changes in this component, it doesn't feel like this fits the criteria for that so I've gone back to minor.