springernature / shunter

A Node.js application built to read JSON and translate it into HTML
GNU Lesser General Public License v3.0
237 stars 28 forks source link

Missing dep mocha-phantomjs-core causes client side tests to fail #311

Closed josebolos closed 4 years ago

josebolos commented 4 years ago

Missing dependency mocha-phantomjs-core causes client side tests to fail on apps build with shunter.

This may have been caused by #218.

$ make test-client
> running client-side unit tests
module.js:478
    throw err;
    ^

Error: Cannot find module 'mocha-phantomjs-core'
    at Function.Module._resolveFilename (module.js:476:15)
    at Function.resolve (internal/module.js:27:19)

Related: #289.

josebolos commented 4 years ago

Fixed by #313, released in v4.13.1.