Closed josebolos closed 4 years ago
This has a few changes which make me nervous. Unless @moddular is confident we can merge, Jose I think we should probably pair up and go through this in some detail next week.
I think this is good to merge, given we intend to remove Themes and also test-client.js
in shunter v5.
This is just a new branch created from
master
with all the changes from https://github.com/springernature/shunter/pull/195 applied, as that request is from 3 years ago so it doesn't merge cleanly. All the merit goes to @andrewmee.Removes the following legacy configuration options which are no longer required:
config.path.themes
- vestigial feature from when a single shunter instance would run multiple apps ("themes"). Now always set to the root directory of the host app, so no longer neededconfig.path.shunterResources
- Shunter no longer contains any default resourcesconfig.path.templates
- unusedAllows custom configuration options to be passed to the Shunter testhelper for testing templates.
Fix bug whereby Shunter would break if a user set a value for
config.structure.templates
other than the defaultview
.This pull request is a work in progress - opening now so I can document changes as I go.
TODO:
local.json
(no reason for this to be done any differently to setting other custom config - might be worth clarifying using the local json file is just an alternative method for setting all config).config.structure.resources
is changed from default (or any other paths referenced in that script)