springernature / shunter

A Node.js application built to read JSON and translate it into HTML
GNU Lesser General Public License v3.0
237 stars 28 forks source link

Remove themes, legacy config options and fix config bugs #318

Closed josebolos closed 4 years ago

josebolos commented 4 years ago

This is just a new branch created from master with all the changes from https://github.com/springernature/shunter/pull/195 applied, as that request is from 3 years ago so it doesn't merge cleanly. All the merit goes to @andrewmee.


This pull request is a work in progress - opening now so I can document changes as I go.

TODO:

jpw commented 4 years ago

This has a few changes which make me nervous. Unless @moddular is confident we can merge, Jose I think we should probably pair up and go through this in some detail next week.

jpw commented 4 years ago

I think this is good to merge, given we intend to remove Themes and also test-client.js in shunter v5.