search

springernature / shunter

A Node.js application built to read JSON and translate it into HTML
GNU Lesser General Public License v3.0
237 stars 28 forks source link

Remove shunter-test-client tool #321

Closed josebolos closed 4 years ago

josebolos commented 4 years ago

The shunter-test-client tool that shunter provides in order to test client side JS hasn't been updated in a very long time. No one seems to be using this feature so we rather remove it so it's easier to maintain.

This PR removes the tool, any required dependencies, plus any references in the documentation and config files.

moddular commented 4 years ago

shunter-mosaic has a lot of test cases that use this, though I guess we could just not update shunter there if we want to go ahead with this change (it's very infrequently updated now)

jpw commented 4 years ago

That makes sense to me @moddular -- v5 is all about dropping support for deprecated things, so you wouldn't be missing out on much for that use case. It is a potential gotcha, but I presume anyone working on shunter-mosiac could be warned (or read the release notes before doing a major version upgrade).

I would hope shunter-mosaic will also be gone in the next 12 months or so -- or at least, there will be no demand to upgrade it.