.github/workflows/test-on-push-and-pull.yml which actually runs the GitHub Actions (GHA) job was already committed. There are some minor amends (ensure we run npm ci in CI, ensure we don't test against node 12 twice when linting)
removing travis config
removing Makefile and build script, as they no longer seem necessary (and modifying npm scripts as a result)
I have to commit the package-lock.json for now, because the GHA actions/setup-node@v3 which installs node before the job runs requires a lockfile to be present, even for libraries. I have raised this issue with the maintainers but in the meantime I would like to get this working as we have a production bug to try to fix.
.github/workflows/test-on-push-and-pull.yml
which actually runs the GitHub Actions (GHA) job was already committed. There are some minor amends (ensure we runnpm ci
in CI, ensure we don't test against node 12 twice when linting)package-lock.json
for now, because the GHAactions/setup-node@v3
which installs node before the job runs requires a lockfile to be present, even for libraries. I have raised this issue with the maintainers but in the meantime I would like to get this working as we have a production bug to try to fix.