run npm i not npm ci in CI and ignore package-lock.json
We run npm i not npm ci in CI (and ignore the package-lock.json) because shunter is a library, not an application. In the event of a change anywhere in the dependency tree breaking the build, or tests, we want to know ASAP to reflect what our users experience.
Running npm ci would result in a deterministic install that would not give us that insight.
This means we do not need the package-lock.json to be in git; but it's required for actions/setup-node GH Action to work.
.gitignore(no meaningful changes)npm inotnpm ciin CI and ignorepackage-lock.jsonWe run
npm inotnpm ciin CI (and ignore thepackage-lock.json) because shunter is a library, not an application. In the event of a change anywhere in the dependency tree breaking the build, or tests, we want to know ASAP to reflect what our users experience.Running
npm ciwould result in a deterministic install that would not give us that insight.This means we do not need the
package-lock.jsonto be in git; but it's required foractions/setup-nodeGH Action to work.