search

springeye / vue-for-idea

This is vue plugin for idea
https://plugins.jetbrains.com/plugin/9188
BSD 3-Clause "New" or "Revised" License
321 stars 45 forks source link

Project leak in attributes provider #28

Closed denofevil closed 8 years ago

denofevil commented 8 years ago

Storing project component inside of the extension point is causing project leak: https://github.com/henjue/vue-for-idea/blob/master/src/main/java/io/j99/idea/vue/component/VueAttributeDescriptorProvider.java#L12.

screen shot 2016-04-28 at 11 19 11

I think this field is not needed, it can be replaced with local variable declaration.

springeye commented 8 years ago

The future will be rewritten. This plugin is currently used for learning

denofevil commented 8 years ago

I find it weird to close the issue that is still present. It's just a matter of deleting 4 lines of code, do you need PR for that?

springeye commented 8 years ago

I don't care about it at the present, for me it is more about learning how to develop plug-ins, and the second is to do it well.