springfall2008 / batpred

Home battery prediction and charging automation for Home Assistant, supporting many inverter types
https://springfall2008.github.io/batpred/
129 stars 44 forks source link

Battery pause error in v8.6.0 #1622

Open SwiftRR opened 3 days ago

SwiftRR commented 3 days ago

Describe the bug Error message in Predbat addon log after upgrading from givTCP v2.4.9 to v3.0.4:

image

in v2.4.9, pause instructions were read successfully (on GE AC3.0, updated firmware), e.g.

image

v8.6.0 Features state: 'Determine automatically if GivTCP V3 is installed and use new REST API for Pause mode'

Expected behaviour No error

Predbat version 8.6.0

Environment details

mpartington commented 3 days ago

The graceful handing part is not really an error. This is the explanation from Mark

"The Critical log is just for me to see how prevalent a fw bug in the Gen1 is. That can be safely ignored, it’s not really an error, in as far as I made the lib handle the none standard function code response properly"

For the second error (pause slot), have you hashed out the pause times in apps.yaml, as they are not available on AC3? Otherwise, maybe it's linked to the new REST control

mpartington commented 3 days ago

Looks like Trefor has already fixed the REST error relating to the pause slot , in main. He doesn't hang around 🤣 Screenshot_2024-11-12-20-20-23-749_com android chrome

SwiftRR commented 3 days ago

Thanks.

My AC3 inverter is late 2022 and does accept Pause mode. I had assumed that Pause start time/end time were also allowed.

I have now commented these lines out in my apps.yaml and have restarted givTCP v3.0.4 and Predbat v8.6.0.

The pause start/end time ERROR has now disappeared.

Rob

mpartington commented 3 days ago

Great stuff! I have the same inverter and it's a register issue, unfortunately there aren't enough spare time for all the functionality the later gens have. AC3 is just pause off/on with no ability to natively set time periods Fingers crossed that's sorted now