springfall2008 / batpred

Home battery prediction and charging automation for Home Assistant, supporting many inverter types
https://springfall2008.github.io/batpred/
129 stars 44 forks source link

Should Load and scaling factors be ignored when in holiday mode? #602

Open gcoan opened 10 months ago

gcoan commented 10 months ago

Describe the bug Follows from a conversation on the GivEnergy forum https://community.givenergy.cloud/d/3696-first-night-live-on-predbat/144

Piansom is away on holiday and so his consumption is fairly flat. Predbat set to holiday mode. Every night excess battery charge is being exported prior to the overnight cheap rate period, but Predbat seems to be getting this wrong and is discharging too much, resulting in import occurring before the next overnight cheap period.

I've advised setting best_soc_keep and best_soc_min, but still not getting the right behaviour.

Looking through the settings and comparing to my own, and looking at the predbat defaults, I am wondering whether the behaviour of metric_inday_adjust_damping and load_scaling should be changed when in holiday mode?

metric_inday_adjust_damping is set to 0.95 load_scaling to 1.15

Holiday mode is on so days_previous is ignored and just yesterday's consumption is being used.

But load_scaling is increasing that consumption by 15% and metric_inday_adjust_damping is reducing it by 5%, resulting in today's consumption not being assumed to be the same as yesterdays.

In holiday mode should these two factors be ignored (i.e. no scaling), or should there be advice given in the documentation to review and change these factors when setting holiday mode?

Expected behavior In holiday mode, today's consumption should be modelled closely on yesterday's consumption.

Predbat version 7.14.36

PianSom commented 10 months ago

One thing that is possibly relevant to note - following a suggestion from Geoffrey I have the following in my config:

  days_previous:
    - 2
    - 3
    - 4
    - 5
    - 6
    - 7
    - 8

  days_previous_weight:
    - 1