springfall2008 / batpred

Home battery prediction and charging automation for Home Assistant, supporting many inverter types
https://springfall2008.github.io/batpred/
105 stars 36 forks source link

Add currency symbol option #819

Closed springfall2008 closed 4 months ago

springfall2008 commented 4 months ago

Is your feature request related to a problem? Please describe. Predbat shows prices in £s

Describe the solution you'd like Add option to change to $'s, Euro's etc.

Describe alternatives you've considered Just ignore it

gcoan commented 4 months ago

should predbat not just pick the currency symbol from Home Assistant rather than having to have yet another manual config item in apps.yaml?On 4 Mar 2024, at 19:36, Trefor Southwell @.***> wrote: Is your feature request related to a problem? Please describe. Predbat shows prices in £s Describe the solution you'd like Add option to change to $'s, Euro's etc. Describe alternatives you've considered Just ignore it

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

springfall2008 commented 4 months ago

Now implemented on main ready for testing, please note I have no idea how to link this to HA directly as its via AppDeamon, but at least you can configure this in apps.yaml now

gcoan commented 4 months ago

I'd forgotten that HA and appdaemon are running as different worlds without a lot of knowledge of each other.

Had a Quick Look and I can't find anything on google that suggests how to do this and its not something that is set in appdaemon either https://appdaemon.readthedocs.io/en/latest/CONFIGURE.html

so a local config in apps.yaml at least makes the capability available to Predbat for our overseas users

Cheers