springfox / springfox-grails-integration

SpringFox integration with Grails 3.x
Apache License 2.0
19 stars 12 forks source link

G3 upgrade #23

Open bmcguire opened 6 years ago

bmcguire commented 6 years ago

@dilipkrish I have went through and got the project working with Grails 3.3.2. This update gets the dependencies and imports updated correctly. The other major change made is to have the DocumentationPluginsBootstrapper not startup with the Spring context but with the Grails Application through the SwaggerGrailsApplicationPostProcessor.onStartup method. This is similar to the way Springs SmartLifecycle interface works but in the context of Grails lifecycle.

I saw the changes in the issue/18 branch but didn't have time to integrate all the changes. I figure this is a release that could be put out sooner to get basic Grails 3.3.X support working. I believe it will be compatible with any Grails 3.X version as well, so backwards compatible, but I haven't fully confirmed that.

dilipkrish commented 6 years ago

wwwwaaat! this is awesome! thank you so much for taking time to look at the upgrade path. 🤘 I'll review and merge