springjools / deluge-autoremoveplus

Auto removing of deluge torrents
43 stars 5 forks source link

Removal of torrents #13

Open Groodles opened 4 years ago

Groodles commented 4 years ago

https://github.com/springjools/deluge-autoremoveplus/blob/5165e1f4f8b2f156f70cc5e4d39b506adeb1a0cd/autoremoveplus/core.py#L618

Surely this should be:

if remove_cond and seed_remove_cond

Otherwise all other specific rules are not referenced at all

springjools commented 4 years ago

Specific rules are referenced for unfinished torrents, it was always this way. Finished torrents are removed using the settings for pause and remove in main tab.

Of course it should not be this way but a fix requires refactoring the code. In fact, the whole plugin should just be specific rules.