Python 3 support - Githubissues

camjac251 commented 4 years ago

Is this supported for python 3? I'm on Python 3.6.10 and tried compiling it with my pipx virtualenv I made for the latest dev version of deluge but got this error.

byte-compiling build/bdist.linux-x86_64/egg/autoremoveplus/gtkui.py to gtkui.cpython-36.pyc
  File "build/bdist.linux-x86_64/egg/autoremoveplus/gtkui.py", line 147
    def on_menu_show(menu, (menu_item, toggled)):
                           ^
SyntaxError: invalid syntax

Similar issue here

Having an issue with the .egg install. Using delugevpn . Doesn't show up in Deluge after.

https://i.imgur.com/HO1qAiv.png

Byte-compiling build/bdist.linux-x86_64/egg/autoremoveplus/gtkui.py to gtkui.cpython-38.pyc File "build/bdist.linux-x86_64/egg/autoremoveplus/gtkui.py", line 147 def on_menu_show(menu, (menu_item, toggled)): ^ SyntaxError: invalid syntax

byte-compiling build/bdist.linux-x86_64/egg/autoremoveplus/mediaserver.py to mediaserver.cpython-38.pyc byte-compiling build/bdist.linux-x86_64/egg/autoremoveplus/webui.py to webui.cpython-38.pyc creating build/bdist.linux-x86_64/egg/EGG-INFO

Originally posted by @exzacklyright in https://github.com/springjools/deluge-autoremoveplus/issues/3#issuecomment-568081574

camjac251 commented 4 years ago

I tried to fix it myself, but not sure if it's proper. I changed def on_menu_show(menu, (menu_item, toggled)): to def on_menu_show(menu, menu_item, toggled):

No error on compilation but when I add it to deluge (latest dev commit) using the unofficial windows build to my linux server (since web will upload as filename [object FileList]. If I try to enable the one uploaded using the windows client, it doesn't enable. It's in the plugins folder but just won't enable

y0da822 commented 4 years ago

Same exact issue here using docker container for deluge from linuxserver.io

y0da822 commented 4 years ago

was able to make this work

With the linuxio deluge docker container, I had to download the autoremover from here https://github.com/springjools/deluge-autoremoveplus then I had to compile it with python 3.6 using python3.6 setup.py bdist_egg. This made the egg file that would work with my container which was running python3.6.

But before it will actually work - this was the real kicker - the docker container from linuxserverio for deluge is missing python library requests ( https://github.com/linuxserver/docker-deluge/issues/87 ). So I had to exec into the container docker exec -it deluge /bin/bash and install the requests module with apt-get update && apt-get install -y python3-requests python3-future . THen I restarted the container and I was able to check turn on the plugin and configure it via the webui.

camjac251 commented 4 years ago

This doesn't work for me as I still get the invalid syntax error. Requests was already installed as a package and in my virtual environment, only python 3 exists so python is python 3.

y0da822 commented 4 years ago

So you see it in the plugins list but when you check it it unchecks itself? Right?

If so what’s your deluge log saying when it tries to load the plugin? That’s where I saw the issue with mine which was missing requests package.

mhertz commented 4 years ago

If anybody wants this plugin in the unofficial deluge2 installer for windows(as mentioned earlier), then here's instructions, and this was done using the nice help of camjac251 and y0da822, thanks guys! :) Note, this plugin can be enabled and used in GTK-UI, but needs actual setting up to be done in webui or from it's config file directly, and then thereafter can be used from GTK-UI, just not can be configured from there.

Anyway, download and unzip this archive linked below, and then copy the plugin to your plugin folder under deluge profile folder(plugin includes fix from camjac251 and is built for py3.8, but can be renamed to suit other python versions), and unpack the contents of deps.zip which also is included in link, into 'InstallDir\Lib\site-packages'.

As stated by y0da822, then requests and past from future(or whole future, if dosen't caring about saving little over 2mb, as I omitted in link), and urllib3 is a dep to requests needed too, as missing from deluge and it's installed deps(The other deps of requests are already installed by deluge's deps).

Note, needs new version of unofficial installer, as just recently changed to py38 and previous was py37, so if using older version, then rename plugin to have py3.7 in name and should work still.

http://s000.tinyupload.com/index.php?file_id=09831498366885208005

Edit: Sorry, missed that future(past specifically) wasen't needed anymore in later commits, so rebuilded above archive without that module added, so use this download link here instead(though the above still works fine, just features a redundant module):

http://s000.tinyupload.com/index.php?file_id=00290673701628685910

Edit2: I rebuilt deluge/installers with both requests and future included, for this and possible other plugins too, so disregard and ignore the deps.zip included in above zip and just use the plugin, but if not updating to newest installers, then you still need the deps.zip though.

Edit3: Since only a single commit added extra since last release of plugin, and not important commit, then might as well just download and use latest release version here, instead of using the plugin I linked previously.