springload / draftail

📝🍸 A configurable rich text editor built with Draft.js
https://www.draftail.org/
MIT License
616 stars 64 forks source link

Edit image after it's inserted #143

Closed robvdl closed 6 years ago

robvdl commented 6 years ago

Maybe I am missing something but I noticed the same thing with the old wagtail rich text editor... Once I've inserted an image and picked left align, if I change my mind later and want to make the image right aligned for example, the only way I can see this working is removing the image and re-inserting it, why is this?

I can't seem to be able to right click on the image, bring up a right click menu to edit it's properties, or if the image is selected click the image button again doesn't bring up the image properties modal either.

Is this by design? that the user always has to remove and reinsert images, it seems a bit counter productive?

Also the new editor has a small icon overlay at the top right of each image, clicking it does nothing but select the image, that seems a bit pointless as I can do this already by clicking the image. I would have expected this to open the image properties modal.

thibaudcolas commented 6 years ago

Hey @robvdl, thank you for taking the time to report this.

As far as I can see this is all specific to how Draftail is used in Wagtail, so this should ideally be reported on the Wagtail issue tracker. There's actually already an open issue for this: https://github.com/wagtail/wagtail/issues/2674.

As you say this works the same way as the previous editor. Building this new behaviour is on the roadmap, but it's not a priority – I'd be happy to help you if you want to make it happen though.

The point of the icon is to distinguish between images and embeds. As you can see in the editor, links and documents also have icons next to them – this is to help with understanding of what content corresponds to what type.


I'll close this here, please proceed in https://github.com/wagtail/wagtail/issues/2674 if you want to discuss this further. On that issue there's already a comment detailing what needs to happen for image edit to be built.