search

springload / draftail

📝🍸 A configurable rich text editor built with Draft.js
https://www.draftail.org/
MIT License
618 stars 64 forks source link

Support full aria controls provided by draftJS #436

Closed dwjohnston closed 2 years ago

dwjohnston commented 3 years ago

Is your proposal related to a problem?

It looks like the only aria tag you are providing is the the ariaDescribedBy.

This makes it difficult to access the component when using React Testing Library.

Describe the solution you’d like

Pass the full list of aria props as listed here on to the draft js component:

https://github.com/facebook/draft-js/blob/master/src/component/base/DraftEditorProps.js

Describe alternatives you’ve considered

It looks like you aren't support arbitrary passing of props to base elements, like Material-UI often does.

Additional context

(Write your answer here.)

thibaudcolas commented 3 years ago

Hey @dwjohnston, thank you for the report, and the PR. Not having those props seems like oversight from my part more than anything.

I’ll triple check how the Draft.js 0.10 -> 0.11 situation might affect this and review your PR.

thibaudcolas commented 2 years ago

Implemented in #438.