Fix toolbar buttons appearing broken when no label or icon is set

thibaudcolas commented 3 years ago

This PR changes two things:

Custom formats without a defined label or icon are now hidden from the toolbar. Those two props have always been optional, but having neither really doesn’t achieve anything useful for users. This also makes it easier to implement custom controls (e.g. color picker for inline styles, or text styles drawer).
Buttons for built-in formats like this can also be hidden by explicitly setting their label to null (thus overriding the built-in labels).

I also added a demo of building a text styles drawer as part of the "controls" doc, which depends on those changes.

[x] Stay on point and keep it small so it can be easily reviewed. For example, try to apply any general refactoring separately outside of the PR.
[x] Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
[x] All new and existing tests pass, with 100% test coverage (npm run test:coverage)
[x] Linting passes (npm run lint)
[ ] Consider updating documentation. If you don't, tell us why.
[ ] List the environments / platforms in which you tested your changes.

Thanks for contributing to Draftail!

github-actions[bot] commented 3 years ago

	Warnings
:warning:	This pull request updates the library. Should the documentation be updated as well?

	Messages
:book:	What labels should we add to this PR?

Generated by :no_entry_sign: dangerJS against 080a64a7c4e967252769df53ec6a8db807308cbf

github-actions[bot] commented 3 years ago

	Warnings
:warning:	This pull request updates the library. Should the documentation be updated as well?

Generated by :no_entry_sign: dangerJS against c39bf8adf4a64bbe6de6b0bdb815c0f0f937bb2d

springload / draftail