Setup linters

[loicteixeira]

Add Linters dependencies & config for Python and JS. Waiting on https://github.com/prettier/prettier/pull/3038 for SASS.

I'll add the steps to the CI after merging.

[holloway]

@loicteixeira It's unclear whether Prettier will adopt the Indenting CSS PR.

They ran a Twitter poll for 30 hours among likely Prettier users who, if they used Prettier, couldn't use the indenting style, and the results were that 9% of about 800 people use the indenting style despite Prettier lacking the feature (presumably they disable Prettier CSS/Sass formatting).

They also seemed to reject far larger polls of about 3400 users where 30% of devs said they prefer an indenting style, based on unsubstantiated suspicions by one dev of theirs.

So it's a very odd situation, and the PR is in limbo right now. It's unclear what threshold needs to be met to accept it, and although the code is complete I wouldn't wait on it.

Sad!

[loicteixeira]

As discussed offline, we will look at either using Prettier with the default indenting style (without the PR mentioned above merged) or something else as it is unclear when/if the PR will be merged unfortunately.

[loicteixeira]

@thibaudcolas:

• It seems that VisualStudio Code does not respect .editorconfig for Makefiles and use tabs of size 4 anyway (which is why it worked so far) but I've added the config as not everybody might use VSCode.
• I've made all the hooks executable and removed the source but FWIW, we can't use return anymore but have to use exit 0 instead as you can only return from within a function or a sourced script.

Edit: I can't quite get the CSS linting to work 😞

[loicteixeira]

Merging without CSS linting as I can't quite get it to work but need to get on something else. I'll create a separate issue to revisit.

[thibaudcolas]

🎉

For me VS Code respects the settings defined for https://github.com/springload/draftjs_exporter, I might have a plugin doing that though not sure.