add show and hide for tags on homepage

springload / madewithwagtail

A showcase of sites and apps made with Wagtail CMS, the easy to use, open source Django content management system

http://madewithwagtail.org

MIT License

85 stars 21 forks source link

add show and hide for tags on homepage #64

Closed cecenz closed 7 years ago

cecenz commented 7 years ago

Close #19.

loicteixeira commented 7 years ago

This looks great @claireynz 🎉 tags

@claireynz, @thibaudcolas: Tags are ordered by name which makes sense when they are all shown. Do you think we should order them by number of posts now, so the most popular are shown without the need to click "show more"? If so, do you think the tag should include the number of posts in it? FWIW, I'm happy to do the back-end part of this.

thibaudcolas commented 7 years ago

Updated with a few changes:

Moved the JS to a separate file.
Cleaned up the HTML and CSS a bit (not related to those specific changes).
The JS performance does not depend on the number of tags anymore.
If JS is disabled, display all tags.
Add ARIA attributes for screen readers to know whether the tags are displayed or not.

@loicteixeira @claireynz could you review?

For your point about ordering Loïc – I think it makes perfect sense to order the tags by number of sites for each. Not sure whether we would want to display that count on the tag though. Would you want to do this in this PR or in another one?

loicteixeira commented 7 years ago

I'm happy to do this part of this PR if you don't mind waiting for a day or two.

thibaudcolas commented 7 years ago

Sounds good 🙂

loicteixeira commented 7 years ago

Done. It will need some styling, leaving it to you @claireynz.

I tackled #44 at the same time.

@thibaudcolas, I had a quick look at your changes and it looks good to me but I'll only approve the PR once we've styled the tag count.

thibaudcolas commented 7 years ago

Cool! @bwjwright you've worked on this project before I think, would you have some thoughts on what this should look like? Should there be a count at all?

bwjwright commented 7 years ago

@thibaudcolas Hello! The numbers are an interesting idea and it's cool to see how many projects are behind a tag instead of clicking into a tag and only finding 1 thing (for example).

You could try put a circle or some other visual behind the number but it might be too much, by default I think it does the job as is. It probably needs some exploration if we want to do something different though.