springload / madewithwagtail

A showcase of sites and apps made with Wagtail CMS, the easy to use, open source Django content management system
http://madewithwagtail.org
MIT License
84 stars 21 forks source link

Makes site URL optional. #72

Closed BertrandBordage closed 7 years ago

BertrandBordage commented 7 years ago

Currently, we must set a URL on a each site. There are some cases where sites are no longer on any existing URLs, so I think it’s better to make this field optional.

Here are cases I met:

BertrandBordage commented 7 years ago

This is because other changes were made to these fields in the past, but no migration was done. By the way, this migration is useless from a SQL perspective, as it changes nothing in the schema. I did it so Django’s migration system doesn’t complain about unmigrated changes in models.

thibaudcolas commented 7 years ago

I see – I vaguely remember making lots of help text changes, was still learning about migrations back then. It might be from this.

I'll try this locally and merge.

NB: Not sure why CodeShip is erroring like that today.