search

springload / madewithwagtail

A showcase of sites and apps made with Wagtail CMS, the easy to use, open source Django content management system
http://madewithwagtail.org
MIT License
84 stars 21 forks source link

Make website and developer titles in to links #90

Closed jennyadamsnz closed 6 years ago

jennyadamsnz commented 6 years ago

Only the site images on the home page are clickable, not the website or developer names underneath and it feels like those should be links too.

thibaudcolas commented 6 years ago

Makes sense to me, and I'm sure screen reader users would appreciate.

When we get to this, I think the best/easiest would be to move the link tag to encompass all of the content:

madewithwagtail-90

jennyadamsnz commented 6 years ago

Could you please expand on why you think this approach would be best? What about the Developer name because a user I'd expect that to link to the developer's page rather than the website page (if it was a link). Thoughts?

thibaudcolas commented 6 years ago

This is all a matter of user expectations regarding the design. I assume not having links directly to the developer's profile is done on purpose – we want this bit of the UI to be more about the sites than about who made them (as reflected by how this piece of text is muted, and doesn't have a link on it).

If we want developer names to link to something else, then it needs to be made clear by visually styling those as links. IMO just adding the link style on this text makes the grid look cluttered, I'd rather keep a focused "each grid item points to a website" approach.

mww-links-90

loicteixeira commented 6 years ago

When you over the image, some additional links appear. Adding links on the text feels a bit redundant which means it's more of a design issue than anything else but I don't have a solution for that.

jennyadamsnz commented 6 years ago

In that case I think either the headings needs to be changed to make the titles less bold (and hinting towards being a link IMO) or links need to be added.

thibaudcolas commented 6 years ago

Closing. I don't think the developer name should be a link, and @loicteixeira's point about the image hover effects means there is good reason for the site title not to be a link either.

We can revisit later but I'd rather involve a designer in the conversation.