search

springmeyer / arc.js

great circle routes in javascript
http://springmeyer.github.io/arc.js/
BSD 2-Clause "Simplified" License
369 stars 69 forks source link

create es6 module #31

Closed amaldare93 closed 6 years ago

amaldare93 commented 8 years ago

I have made a new file that is identical to arc.js, but has ES6 module exports so that it will be compatible with ES6 bundlers such as Rollup.js.

I have also added jsnext:main: to the package.json. This is so that Rollup can find the ES6 module file; other module loaders will still read from the main file, and should be unaffected by these changes.

springmeyer commented 8 years ago

Thanks for this contribution. Can you think of a way to avoid the code duplication?

amaldare93 commented 8 years ago

Yes, I will try to look for a way to shove it in the main file into that conditional at the end maybe.

I'll get back to you tomorrow about it. On Apr 17, 2016 2:26 AM, "Dane Springmeyer" notifications@github.com wrote:

Thanks for this contribution. Can you think of a way to avoid the code duplication?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/springmeyer/arc.js/pull/31#issuecomment-210965564

amaldare93 commented 8 years ago

Hey, sorry for the delay, i spent the last 4 days working on a way to automate the es6 module generation, and then i realized that #26 alone fixes my original problem (requiring arc in Rollup) and i noticed that even though it was merged in November, it was never published to npm. Would it be possible for you to publish the latest version of Arc to npm?

If there is some reason you don't want to do that, I suppose i can try to npm install from the git repo, but I'm sure many others would benefit from the publishing.

daumann commented 6 years ago

@springmeyer any updates on this? Could you publish the ES6 ready version (necessary also for react/ webpack setup)?

springmeyer commented 6 years ago

@daumann as far as I can tell there is no need for this given:

then i realized that #26 alone fixes

Looks like I just need to publish a new version. Sound good?

springmeyer commented 6 years ago

26 is now published in arc@0.1.1