springmeyer / arc.js

great circle routes in javascript
http://springmeyer.github.io/arc.js/
BSD 2-Clause "Simplified" License
369 stars 69 forks source link

Demo problem #42

Closed valerio-bozzolan closed 2 years ago

valerio-bozzolan commented 2 years ago

Hi all!

I was not able to visit the demo in https://

https://springmeyer.github.io/arc.js/

Having said that also in http:// I'm not sure everything is working. Are you aware of that? Thank you so much :)

jgravois commented 2 years ago

hi @valerio-bozzolan 👋

the demo doesn't work using https because the CDN its using isn't available over https

http://cdn.leafletjs.com/leaflet-0.7.3/leaflet.js

the demo runs using http, the tiles just aren't loading ex: http://a.tiles.mapbox.com/v3/springmeyer.map-7jkxlsx1/2/1/2.png Screen Shot 2022-02-15 at 8 45 02 AM

to get things ship shape you'll need to swap in a different leaflet CDN and some different tiles.

https://leafletjs.com/examples/quick-start/

valerio-bozzolan commented 2 years ago

Uhm. Maybe the OpenStreetMap default tiles are nice enough instead of MapBox. Also I see that upstream they suggest another CDN:

https://leafletjs.com/examples/quick-start/

valerio-bozzolan commented 2 years ago

Here we are:

https://unpkg.com/leaflet@0.7.3/dist/leaflet.js

valerio-bozzolan commented 2 years ago

What. That CDN has inconsistent content about that version. Having said that we won't have noticed the difference and we can use that version as well, let's file a bug upstream just to notify that.

https://github.com/Leaflet/Leaflet/issues/8004

valerio-bozzolan commented 2 years ago

Thanks!