search

springmeyer / arc.js

great circle routes in javascript
http://springmeyer.github.io/arc.js/
BSD 2-Clause "Simplified" License
369 stars 69 forks source link

Fix error with antipodal error generation #43

Closed blaine-foreflight closed 2 years ago

blaine-foreflight commented 2 years ago

The "start" and "end" variables referenced in the error message were not of type Coord, and the code would crash since the .view() function didn't exist. This PR makes changes to reference the correct variables.

blaine-foreflight commented 2 years ago

Anything more I should do for this to get merged??

jgravois commented 2 years ago

fwiw, i'm not a maintainer of this library.

it hasn't seen much active development in the last few years but your PR will get 👀 on it eventually.

springmeyer commented 2 years ago

Thanks so much for this fix @blaine-foreflight and to @jgravois for providing review.