search

springmeyer / arc.js

great circle routes in javascript
http://springmeyer.github.io/arc.js/
BSD 2-Clause "Simplified" License
369 stars 70 forks source link

Fix Leaflet inclusion #9

Closed mourner closed 12 years ago

mourner commented 12 years ago

Currently the demo page is broken because the Leaflet master API has GeoJSON class changed slightly (addGeoJSON method renamed to addData). The page includes Leaflet like this: 

<script src="https://raw.github.com/CloudMade/Leaflet/master/dist/leaflet.js"></script>

This is an extremely bad practice as your code is always prone to breaking, as master branch is an in-progress development version. You should either link to stable version (e.g. with Leaflet CDN http://leaflet.cloudmade.com/download.html), or put the master version files into your repo and update manually.

springmeyer commented 12 years ago

Hi, Thanks for the heads up Vladimir! Fixed now.

mourner commented 12 years ago

Awesome, thanks :) Great work BTW!