search

springtestdbunit / spring-test-dbunit

Integration between the Spring testing framework and DBUnit
http://springtestdbunit.github.com/spring-test-dbunit/
Apache License 2.0
475 stars 238 forks source link

Upgraded dbunit to 2.5.1 and added support for allowEmptyFields config #80

Closed chintadas closed 8 years ago

chintadas commented 9 years ago

There was a new config parameter added to allow empty field values which has a default value of false. This config parameter could not be added through the DatabaseConfigBean, so added getter and setter for this DatabaseConfig.FEATURE_ALLOW_EMPTY_FIELDS.

see http://sourceforge.net/p/dbunit/bugs/363/ and http://sourceforge.net/p/dbunit/code.git/ci/2a461dd1853abaf8af4b7f66cc84214c60206b1f/

Not sure if I followed conventions. Please review.

buildhive commented 9 years ago

springtestdbunit » spring-test-dbunit #65 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 9 years ago

springtestdbunit » spring-test-dbunit #66 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 9 years ago

springtestdbunit » spring-test-dbunit #67 FAILURE Looks like there's a problem with this pull request (what's this?)

chintadas commented 9 years ago

Is JDK8 installed on the jenkins building this project?

jmerljak commented 9 years ago

Java version could probably be reverted to 1.5. Is there any particular reason to upgrade?

chintadas commented 8 years ago

There is one commit that upgraded to jdk8 https://github.com/springtestdbunit/spring-test-dbunit/commit/08f6d48e37442ce624a98add01ed6e145c1d34e6 I think there are some jdk8 features used in that commit but I didn't look carefully. BTW where is this project being built now. Buildhive doesn't seem to be active anymore.

rndmania commented 8 years ago

why don`t merged? it is required feature for many people

philwebb commented 8 years ago

Fixed in c2a68a0ba38097865e31fa1603292da25b7ab182