NetClient.SendMessage has no return value

springtg / lidgren-network-gen3

Automatically exported from code.google.com/p/lidgren-network-gen3

0 stars 0 forks source link

NetClient.SendMessage has no return value #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

http://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Networ
k/NetClient.cs#87

One of NetClient.SendMessage overloads doesn't return any value, there it is 
impossible to check if sending failed.

Original issue reported on code.google.com by NN1436401@gmail.com on 5 Aug 2010 at 1:47

GoogleCodeExporter commented 9 years ago

Thanks, fixed in revision 88

Original comment by lidg...@gmail.com on 5 Aug 2010 at 1:58

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Not fixed in NetConnection:

http://code.google.com/p/lidgren-network-gen3/source/browse/trunk/Lidgren.Networ
k/NetConnection.cs#651

public void SendMessage(NetOutgoingMessage msg, NetDeliveryMethod method)

While other overload does return bool

public bool SendMessage(NetOutgoingMessage msg, NetDeliveryMethod method, int 
sequenceChannel)

Please fix it.

Original comment by NN1436401@gmail.com on 12 Sep 2010 at 4:00

GoogleCodeExporter commented 9 years ago

Fixed in rev 116

Original comment by lidg...@gmail.com on 12 Sep 2010 at 8:00