search

springuser2014 / wro4j

Automatically exported from code.google.com/p/wro4j
0 stars 0 forks source link

Add granular destinationFolder control for maven plugin #78

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
First of all - great plugin, I've been battling with various other plugins
that claimed to have the same sort of functionality and this is the first
one that Just Worked :)

My only enhancement request is to allow finer control over where a specific
resource type ends up instead of just having the processed resource being
spit out to destinationFolder.

For example:

If destinationFolder = /foo/webapp/ and I have a group named "bar" that
contains both css and js resources, the resulting resources will end up at
/foo/webapp/bar.css and /foo/webapp/bar.js.

It would be nice to have some sort of override (perhaps as an additional
optional attribute either on either the group, css or js elements named
"destination") so that if provided, it would process the resource and dump
it out to destinationFolder + additionalFolder.

eg. destinationFolder = /foo/webapp/, group named "bar" with an override of
"js" would end up as /foo/webapp/js/bar.js

Again - thanks for something that worked out of the box, keep up the good
work :)

Original issue reported on code.google.com by ckashu...@gmail.com on 21 Apr 2010 at 1:47

GoogleCodeExporter commented 9 years ago

Original comment by alex.obj...@gmail.com on 21 Apr 2010 at 3:46

GoogleCodeExporter commented 9 years ago

Original comment by alex.obj...@gmail.com on 21 Apr 2010 at 3:48

GoogleCodeExporter commented 9 years ago 
Hi!
Thank you for adding a new issue to wro4j tracking system!
Could you, please, post the request also to discussion list: 
groups.google.com/group/wro4j ... I don't think I completely understand your 
request. 
We can continue the discussion there.

Thanks!
Alex

Original comment by alex.obj...@gmail.com on 21 Apr 2010 at 4:03

GoogleCodeExporter commented 9 years ago 
I've added the ability to change the destination folder for each resource type. 
As a 
result, two optional attributes has been added: cssDestinationFolder and 
jsDestinationFolder. If any of them are present, it will be used as an output 
folder 
for css resource types and js resource types respectively.

Original comment by alex.obj...@gmail.com on 22 Apr 2010 at 1:01

GoogleCodeExporter commented 9 years ago

Original comment by alex.obj...@gmail.com on 22 Apr 2010 at 1:01

GoogleCodeExporter commented 9 years ago 
Hi, sorry I tried to post to the discussion group to clarify what I meant, but 
it did
not seem to want to allow me to post the new discussion.

Anyway! Spot on about what I was asking for, so thank you :)

My original solution was to include a new attribute for the group node inside 
wro.xml
that would have allowed for per-group destination folders, but the more I 
looked at
the existing wro4j code, the more I realised it would have been a giant pain to 
do
and would have ultimately led to some extremely fragile situations when it came 
down
to collecting groups recursively (through the group-ref node). So your 
implementation
works out just great for my purposes.

Thanks for the quick and positive response!

Original comment by ckashu...@gmail.com on 26 Apr 2010 at 4:54

GoogleCodeExporter commented 9 years ago 
The posting on mailing list should work. The only reason why you don't see 
immediately 
is because it awaits moderation. To allow posting without moderation you should 
subscribe the mailing list. The main purpose of this restriction is to avoid 
spam. 
Thanks for your feedback.

Original comment by alex.obj...@gmail.com on 26 Apr 2010 at 5:11