search

springweblobby / swl-website

Weblobby site component
10 stars 11 forks source link

SWL doesn't properly download/run spring dev builds. #91

Closed DeinFreund closed 8 years ago

DeinFreund commented 8 years ago

Downloads as 103.0.1-124-g976888c develop Tries to execute as 103.0.1-124-g976888c

DeinFreund commented 8 years ago

https://github.com/springweblobby/swl-website/blob/master/store/ZkLobbyServer.js#L465

Could add " develop" to end of engine version string if it's a dev engine.

Anarchid commented 8 years ago

That's what is already being done during download, and is why downloads succeed. I guess since ZK seems to keep this naming scheme, makes sense to reuse that logic.

See https://github.com/springweblobby/swl-website/blob/master/store/MBattle.js#L76 and https://github.com/springweblobby/swl-website/blob/master/store/ZkLobbyServer.js#L521

DeinFreund commented 8 years ago

Why isn't it limited to zkls in MBattle?

db81 commented 8 years ago

I don't remember but it was either just in case, or it was added before zkls split.

db81 commented 8 years ago

Blindfoxed by @Anarchid.